-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add mcxaxx6 flexcan support #97929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add mcxaxx6 flexcan support #97929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should have been split into two PRs? One for each HW feature?
22881d8
to
97becd7
Compare
Add mcxa flexcan clock support Signed-off-by: Neil Chen <[email protected]>
Add Flexcan0,Flexcan1 node to NXP MCXA366,MCXA266 dtsi file Add Flexcan0 node to NXP MCXA346 dtsi file Signed-off-by: Neil Chen <[email protected]>
Support Flexcan for NXP frdm_mcxa366,frdm_mcxa346,frdm_mcxa266 board Signed-off-by: Neil Chen <[email protected]>
Enable the full range of CAN timing tests on the NXP FRDM-MCXA366, FRDM-MCXA346 and FRDM-MCXA266 boards. Signed-off-by: Neil Chen <[email protected]>
97becd7
to
c1a8f00
Compare
|
can_timing test pass on mcxaxx5 platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that enabling CAN2.0B is a step forward, I think introducing support for MCXAXX6 should be complete and verified, especially since the hardware supports CAN-FD. Merging partial functionality could lead to confusion or technical debt down the line as already seen on the MCXN947 As seen in #91138 and #95097, similar issues have already been flagged, and a resolution path is available. I’d prefer we address those first to ensure full CAN-FD support is enabled and properly verified for the new hardware before merging this PR. Alternatively, if we proceed with merging partial support, the documentation should explicitly clarify that while the hardware supports CAN-FD, the current software implementation does not enable it. As it stands, the documentation could be misleading and may contradict this reality, so it’s important to update it accordingly to avoid confusion.
This will help manage expectations and avoid confusion for downstream users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with @PetervdPerk-NXP, stating flexcan support means it must support CANFD (and can optionally run/support 2.0B). Not the other way around.
https://docs.nxp.com/bundle/UM12018/page/topics/flexcan_interface.html#
Add flexcan support for frdm_mcxa366,frdm_mcxa266 and frdm_mcxa346