Skip to content

Conversation

NeilChen93
Copy link
Contributor

@NeilChen93 NeilChen93 commented Oct 20, 2025

Add flexcan support for frdm_mcxa366,frdm_mcxa266 and frdm_mcxa346

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should have been split into two PRs? One for each HW feature?

@NeilChen93 NeilChen93 force-pushed the add_mcxaxx6_flexcan_flexio_trng_support branch from 22881d8 to 97becd7 Compare October 21, 2025 02:26
@NeilChen93 NeilChen93 changed the title Add mcxaxx6 flexcan flexio trng support Add mcxaxx6 flexcan support Oct 21, 2025
@zephyrbot zephyrbot requested a review from nashif October 21, 2025 02:28
Add mcxa flexcan clock support

Signed-off-by: Neil Chen <[email protected]>
Add Flexcan0,Flexcan1 node to NXP MCXA366,MCXA266 dtsi file
Add Flexcan0 node to NXP MCXA346 dtsi file

Signed-off-by: Neil Chen <[email protected]>
Support Flexcan for NXP frdm_mcxa366,frdm_mcxa346,frdm_mcxa266 board

Signed-off-by: Neil Chen <[email protected]>
Enable the full range of CAN timing tests on the NXP FRDM-MCXA366,
FRDM-MCXA346 and FRDM-MCXA266 boards.

Signed-off-by: Neil Chen <[email protected]>
@NeilChen93 NeilChen93 force-pushed the add_mcxaxx6_flexcan_flexio_trng_support branch from 97becd7 to c1a8f00 Compare October 21, 2025 02:40
@sonarqubecloud
Copy link

@hakehuang
Copy link
Contributor

can_timing test pass on mcxaxx5 platforms

@henrikbrixandersen henrikbrixandersen removed the area: PWM Pulse Width Modulation label Oct 21, 2025
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@PetervdPerk-NXP PetervdPerk-NXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCXAXX6 supports CAN-FD yet this PR only enables CAN2.0B.
Same issue as #91138
#95097 could be a potential resolution for this issue.

@henrikbrixandersen
Copy link
Member

MCXAXX6 supports CAN-FD yet this PR only enables CAN2.0B. Same issue as #91138 #95097 could be a potential resolution for this issue.

I don't see this as a reason for blocking the introduction of this PR?

@PetervdPerk-NXP
Copy link
Contributor

Hi @henrikbrixandersen,

While I agree that enabling CAN2.0B is a step forward, I think introducing support for MCXAXX6 should be complete and verified, especially since the hardware supports CAN-FD. Merging partial functionality could lead to confusion or technical debt down the line as already seen on the MCXN947

As seen in #91138 and #95097, similar issues have already been flagged, and a resolution path is available. I’d prefer we address those first to ensure full CAN-FD support is enabled and properly verified for the new hardware before merging this PR.

Alternatively, if we proceed with merging partial support, the documentation should explicitly clarify that while the hardware supports CAN-FD, the current software implementation does not enable it. As it stands, the documentation could be misleading and may contradict this reality, so it’s important to update it accordingly to avoid confusion.

- 1x FlexCAN with FD, 1x RGB LED, 3x SW buttons

This will help manage expectations and avoid confusion for downstream users.

Copy link
Member

@bperseghetti bperseghetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @PetervdPerk-NXP, stating flexcan support means it must support CANFD (and can optionally run/support 2.0B). Not the other way around.

https://docs.nxp.com/bundle/UM12018/page/topics/flexcan_interface.html#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants